Skip to content

New culling strike logic, add rarity dropdown #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

New culling strike logic, add rarity dropdown #618

wants to merge 1 commit into from

Conversation

@pauloday
Copy link
Contributor

@pauloday pauloday commented Jan 26, 2025 •
edited
Loading

Fixes #93

Description of the problem being solved:

Currently culling strike is still calculated as 10% for everything. Also culling strike threshold increases don't do anything. This PR fixes both issues, and adds a monster rarity dropdown in the config tab with the various default cull thresholds implement as well.

Steps taken to verify a working solution:

  • Ensure "Culling Strike" row in "Other Effects" table on calcs is 6.25%
  • Unallocate "Cull the Hordes" on the passive tree
  • Verify "Culling Strike" is now 5% in calcs tab
  • Switch "Is the enemy a Boss?" to "No" in config tab
  • Ensure monster rarity dropdown appears
  • Select each option in the dropdown and check "Culling Strike" with and without "Cull the Hordes"
    • Normal should be 30%/37.5%
    • Magic should be 20%/25%
    • Rare should be 10%/12.5%
    • Unique should be 5%/6.25%
  • Unallocate "Pitiless Killer" from the Witchhunter tree
  • Ensure culling strike is still active on unique/boss enemies (due to the Culling Strike gem supporting Sunder)

Link to a build that showcases this PR:

eNqlW1tz4rgSfh5-hYuqU7VbJwHb2FxSZLfIbZI9YcJAMrPnvEwptgBtZIuxZRJma__7aUk2GAYZm8zDjJH6a3W31OqLPf3f3wJqLHEUExae162GWTdw6DGfhLPz-tPjzWm3_vtvtf4I8fnD9CIhVMzYv9U-9OUPg-IlpgBs1w2Pojj-hAJ8Xh_iyMMhilZ1A8Xw5F9u5r4S7s3nSchxVDc4imaYf8nWN79ZwGeOIuTB9L3gPUg4GzIfgDxKcN0IEAknzHvB_GPEkgUsXTeWBL8qmrvh6GH8WAf5PvRHFK1wNOGIGzH8dV4fgJ5ohq9QAH8DCtEEILbba7S7PdftmS2n1ak3C8EXSRTz4zhMFhj7a5DZcLqA6fZ6pttq210dahTh6-kUe5ws8WVE-OUchd5mbcvUAfcQ94pohwnlZEGJ2JaUvqWjv_2ZtVaOR8YRvRpNNiLb7Uav03Edp93q2u1iHOMbix2izC-iN0tCKRzhPK3dbXRdp9UDiUAerdJjHONoiTic1HIrseCZhNgfLGeVD1uE0cNU7fsY-SSJh5hHOM6dHu1eDlGILlm8sZvlmEW0I-mrfAtyCDDBHgOnzkPa3YbjOrbbbXdcs9MrseJ-Ptql78kUl6espFUKqCrNcXpcT8rSVWZ8nEBjuMvKUU5YQktS8s0t0mnrPep7ntA2XR3lFX7bnGdLR3UXbkTr6FktmfDhkvfK9e1oTelYZsPqtqxe1-yYXUd7Zc9XMfEQHaI3EiQBXJaP6AWHeTb6YzWb8xDuJx3W7mnvpxsS4SNgl4z6x8DmiMVHaDiE-H2LQn_geQmE-VUukhU6WxneEGG9M0F8F3pr-m4R16cwkrd6LjAX7s4Uj8GzRCrwTHFZyGaR1EHL6jzGMxymC67K3Un3GHvzj2BjWAq2pdyNnpOnW2hbQZy3bSHXPbYt4L-NqGAoAdxvKKfRKgJVNtVkQSJSSiZFudcApTEVTHAd4mi2mswJpn6JOJGjzmx2iRZl9IcjkEeXOgrby1U60Hlo5d0SYa3qeksU5yNDxy02hSIv5xCYYgwAH-8kzi194s_-Emk_rQYbRAFLopKbqYhLKZAFNVX7jLGfeOWi6Lp6uaBQtu2ocRgFclJaCTrgHHkvV8yf4bIQuUglxLZ8k2SxAL8Vp6EsAxGtoaIguWzq1ClB_QBHuZS3irhefoENdekF1rlK-VV2IOV1EcnGzjJliEsvsN7OIVwVAVy7slgfstzNrd0aKChL1YOSsGSVOmKvIPlcdEfiatSQkh2-JG4iHP5Ylea_RV5qgevQh-wOHKH0GruIfctcJNNpbHhQVyN-D9t7Xq8bzzCWPUNGGeP0h0I8kgAu3ji-QhwZfpr5f0ERQSG3Ze8oxijy5gJ0gyh9hptDcNqMil87QCs7Df2mbIKJp7tgwSJu4DfxzwhFfHVenyIaY0UoR4BPzEkoOwhwTVFaNyZz9jrwl0LvR8ZonIEMtFjg0N_i8RhhbKDs0vGEEFJH8cMIUMwhxqlzHAuhc423O1-qGjIQ4LzudruWc9LpONaJ3XU6J7bjnDi9tts5abdcu33SardgqmPZ5onrWHbnxHW7pn3idGH6BCp8E8Z7wANmHQtAVq_TOnHNXrcN4z0LaCyrA7O2ZbsnttVxXaC0u8ChZbXEeMt1hIVFhYqi1WBbzpCAWTioutMUzOZtqfSH_tP4Xj58mHO-iM-azdfX18YC8Tmb4jcImg04Js0FgMBcp_ELofRUcG0O4M_F7O7iBn89vf3LvL99vTJfp6HzB2tZpv3tf6dRq7OYPS7a_mTcnf_5_bJ99bhyrafT3uf_fL9dDmezwUAK0Mwk6Kt2ZNxUv8SdExGwtBKvD-EoIs8Jx9kEHIO3T2or6gYJ-fo55lH6rOyb2jpnfblfaq_k_qkN-9nSamfkRtdTsZpbcvWb4tTIIyyOlXj4xLiaE4PZj_5EWC42YjjVH3EQX6zg-roR-dimvyUvtPRcCuoJ5sqz8pisfevjKUqoGP-cIEqEm5j50XvVTw5ZFKwLaGAFbiJirOL4uFoIIw3u71MHSFc1iJ85RToou8WDjWiXiHqxFI6EHk18KBTT6zs9eBQ9i-VFE1xUeH6-65zjs17mQx_kSYk_UvaMqJ1B0s64bda35q1sfqkuE3GmJ0noi7arPKabAXVH1o3vOUvNcCAIhpgjH-605h0HCzeFmZtSMnjKuIUoSC-KbGRHKY8lIV9HthK6WIdVSdurEzjzLzjdsi3F5MgWVSU1m5tjsMUkr246YWQzxWr3leFSr0iPkvQMdfbFozw3kuIuXCRcrnVeD0jsfRPxR7x7kO4r35pc39xcXz7efblOY1AeIg3xLUyCZ7lD8t9NbjHBMqc24uQ5Vo_n9S8Ev0pBrsAWhMZCfkrRIsbr6CDPfSo5BVwBN0kF5VP2BmM_rw2BntP1G44gmM2-QqCMCNbKtZ4_IJRaUBRqImbruIn3AXpGKvO_hFA4RlzLQ72H0XMRL0O06ojJAiykAYhqV05nD1iCi-sNDjKZEk8kSMVbLi5DRVVgl3WvTbvfadmi53FB5dur_QzUpB48YiQWteJ-dDpbYNVZSPT7mc7q4VfYQ1rd1aQevO47sFC2HfZzWVMVcPrEQnnIwWkGhIoiQ7uz1xSvSfQMH_gcR2nGp-M0hDsqIyl0HJWjaPnkKApsJfu0GguJOT1UtSE1Ooi5AqdJ23I6byfFLrvdPNPsR55Gz0oVnVobpgVswTakvRvNFqjZAk2y9pVGiXS6wFHkHTxYMuKrJobGZXbIii4NSI3fz0Z2Zt7PZrdV836ON1CVvGj3O53Vw584ERnPHi4qUynFRDjW-zgI_3ofB1GzB0ejx7upyAY7Lk5C1t2FveBstsj306bD0RxUa-RouOzcHI2WAeAKTzFoUBgB1jQFzsGT8AqMwQscoyQrKdb-W2SjXSVeKhbu1bQyR-Xd6fvKogtAkRxgBMH8tiBdLMdp3X28xYjy-Ygx-j6GP72XfQ8z8f4kWaDQz9g97EvSN_tQ0nqMx8BTNtCuxGua99owxMFqDyO9XP1mVtbJ1pootNK-HxSOogfwg7Hgv-f1U8sUX-10OlbLtNotNZ72KSwzbU5ABn5FYBsjefyyZQXln8DBbtkN17bcttuxgYdaXta0aeNEPK_7Jnp-SYzVlx1fMVqwUCJE30LVmcAjK8VFnyzfDhnDMF-dGU-f7j4_XdduIhbz5wgjPq9NKAmMIfJwLW1vnhmjCBtmw2pYm6HLJAJReE1VmNg31jN2Le3kwKNZk3YZ4-9nhmXWoN6hxAP3ODPM2t-paGfWP3_DnTvDZ2bD_Wfg-7Hxi3Pa_tXgzPile2rZvxrZuyZDbdkGav8MVQiBtdqntlkAPryueAly1Joa4L_dfwkqUTNKicCBDFVo1QY0E9CYRiwQU7HxSvjc4HMSG2p_gW-Ypd2CEQQb_AMb0meSRW27z2GgGdQfMQcq9gOHhnAIqLtli2PI_LHQwZCaiM_H3Ox4pE0QLYV9kKJ1kMI5SOEepMi-55GtoPV5F10_nVNstwMp4waUicHo-Wl8L7xbNWQ-UrYUEUVMiY6TmQmiA6Q7Y20g1iGITIDyiIOLDIKEYl4BIBMwo1UZUUUopYZd3VZVIBeY8iN2w5i8itd8pXFj4Td75ZK9_DsfqOX7EjEp34JkyD_wK6ZGOpTnfEgx5q-MrMCrbMGj9LMqH4cqO3WLISmrslcXjPGfPU05dNZylTFRdlxZOCWzNDqqH2l8lKD1yJaT5zutWOQDd_EFi-NNa_YTC3Em5ohCzJvDxY2jPCT9SjtrzXZM8wAg_511hnL1mGD9mfVXInJb7E9k01I0pSG4TnNd4QIuMZkR-jCV5QPgZQ20003WCrxuE2SAdkePmMzBIaSEFVbIAh6c3pcQau1dvH3Iptsfm2yAToFJJh6TqVs1UdPPWSBflGEnv_EHkJkvZ4Buu4RVdhVqFaxyORcd_f36QO6aeYDKZOWv32r95k__U-P_YuELGg==

Before screenshot:

Screenshot_20250125_203231

After screenshot:

Screenshot_20250125_203401
Screenshot_20250125_203335

@pauloday pauloday force-pushed the implment-new-culling-strike branch 3 times, most recently from f564000 to 498d411 Compare January 26, 2025 02:45
@pauloday pauloday marked this pull request as ready for review January 26, 2025 02:46
@pauloday
Copy link
Contributor Author

pauloday commented Jan 26, 2025

Currently the thresholds are hard coded but probably shouldn't be. I wasn't sure where to put them, maybe instead of a "CullingStrike" flag it could be a list with the thresholds. Also I just realized I forgot to update the gem, I'll go do that now.

@pauloday pauloday marked this pull request as draft January 26, 2025 02:54
@pauloday
New culling strike logic, add rarity dropdown
0309217 
Replace the "CullPercent" mod with "CullingStrike" flag. Add rarity
dropdown to config tab, hidden when boss is selected. Add
"CullThreshold" mod. Use all of these to implement new 30/20/10/5 cull
logic.
@pauloday pauloday force-pushed the implment-new-culling-strike branch from 498d411 to 0309217 Compare January 26, 2025 03:13
@pauloday pauloday marked this pull request as ready for review January 26, 2025 03:19
@Blitz54 Blitz54 mentioned this pull request Feb 25, 2025
Merged
@Paliak Paliak added the enhancement New feature, calculation, or mod label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Culling Strike to PoE 2 Implementation

2 participants

@pauloday @Paliak